[msbuild] Sign Xamarin.iOS.Tasks.dll and Xamarin.Mac.Tasks.dll. Fixes #9835.#12831
[msbuild] Sign Xamarin.iOS.Tasks.dll and Xamarin.Mac.Tasks.dll. Fixes #9835.#12831rolfbjarne merged 2 commits intodotnet:mainfrom
Conversation
…ks.dll. This is required for strong-naming to work properly (otherwise all assemblies will have the same version).
…otnet#9835. We need to strongname our MSBuild assemblies, so that different versions can be loaded side-by-side (one example being having both a legacy and a .NET project in the same solution). This also required signing the corresponding test assemblies, since they poke into the internals of the task assemblies. Fixes dotnet#9835.
chamons
left a comment
There was a problem hiding this comment.
I have a foreboding feeling that this will come back again, as every time I've dealt with strong naming there was some issue.
PR looks great though.
|
|
||
| [assembly: AssemblyCompanyAttribute ("Microsoft Corp.")] | ||
| [assembly: AssemblyFileVersionAttribute (VersionConstants.XamarinMacVersion)] | ||
| [assembly: AssemblyInformationalVersionAttribute (VersionConstants.XamarinMacVersion + "." + VersionConstants.NuGetPrereleaseIdentifier + "+" + VersionConstants.NuGetBuildMetadata)] |
There was a problem hiding this comment.
I would have prefer string interpolation ;)
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 136 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
|
Test failure is unrelated (https://github.com/xamarin/maccore/issues/2414). |
mauroa
left a comment
There was a problem hiding this comment.
Should we add the same for Xamarin.iOS.Windows.Tasks.csproj? It contains the HotRestart and Windows Tasks/Targets
Yes, I think it would be a good idea. I think that can be done in a different PR though. |
We need to strongname our MSBuild assemblies, so that different versions
can be loaded side-by-side (one example being having both a legacy and a
.NET project in the same solution).
This required setting a version for Xamarin.iOS.Tasks.dll and
Xamarin.Mac.Tasks.dll, otherwise strong-naming won't work properly (all
versions of an assembly would have the same identity).
Also sign the corresponding test assemblies, since they poke into the
internals of the task assemblies.
Fixes #9835.