[dotnet] Support SupportedOSPlatformVersion. Fixes #12336.#12638
[dotnet] Support SupportedOSPlatformVersion. Fixes #12336.#12638rolfbjarne merged 6 commits intodotnet:mainfrom
Conversation
* Add support for the SupportedOSPlatformVersion MSBuild property, and write it to the Info.plist for the corresponding minimum OS version. * If there are any minimum OS version in the Info.plist, and show an error if it doesn't match SupportedOSPlatformVersion. This unfortunately means that if there's any minimum OS version in any Info.plist, then that will most likely have to be moved to the SupportedOSPlatformVersion property (or removed entirely if that's the right choice), since it's unlikely to match the default value for SupportedOSPlatformVersion. However, this was deemed to be the best option for the future (it's a one-time pain during migration). Fixes dotnet#12336.
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 201 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
…h the Info.plist value (for projects that must share Info.plist with legacy tests).
| "replaces": "minOSVersion", | ||
| "datatype": "string", | ||
| "defaultValue": "11.2" | ||
| "defaultValue": "14.0" |
There was a problem hiding this comment.
why ? it's still 11.2 for iOS
which I assume is to use the new UIScene API as they are newer than the 10.0 minimum ?
There was a problem hiding this comment.
I'm not sure what happened here 🤔
| return false; | ||
| } else if (!string.IsNullOrEmpty (convertedSupportedOSPlatformVersion) && convertedSupportedOSPlatformVersion != minimumOSVersionInManifest) { | ||
| // SupportedOSPlatformVersion and the value in the Info.plist are not the same. This is an error. | ||
| Log.LogError (null, null, null, AppManifest, 0, 0, 0, 0, "The {0} value in the Info.plist ({1}) does not match the SupportedOSPlatformVersion value in the project file ({2}).", minimumVersionKey, minimumOSVersionInManifest, SupportedOSPlatformVersion); // FIXME: add tests + translated string. |
There was a problem hiding this comment.
// FIXME: add tests + translated string.
There was a problem hiding this comment.
@spouliot fixed now (I'd already written the test, so I just had to localize the message).
✅ [PR Build] Tests passed on Build. ✅Tests passed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): 🎉 All 203 tests passed 🎉Pipeline on Agent XAMBOT-1094.BigSur' |
it to the Info.plist for the corresponding minimum OS version.
error if it doesn't match SupportedOSPlatformVersion.
This unfortunately means that if there's any minimum OS version in any
Info.plist, then that will most likely have to be moved to the
SupportedOSPlatformVersion property (or removed entirely if that's the right
choice), since it's unlikely to match the default value for
SupportedOSPlatformVersion. However, this was deemed to be the best option for
the future (it's a one-time pain during migration).
Also add new tests, update existing tests, and update the templates.
Fixes #12336.