Skip to content

[dotnet] Globalization works for Mac Catalyst now. Fixes #11392.#12247

Merged
rolfbjarne merged 2 commits intodotnet:mainfrom
rolfbjarne:dotnet-globalization-mac-catalyst
Jul 28, 2021
Merged

[dotnet] Globalization works for Mac Catalyst now. Fixes #11392.#12247
rolfbjarne merged 2 commits intodotnet:mainfrom
rolfbjarne:dotnet-globalization-mac-catalyst

Conversation

@rolfbjarne
Copy link
Member

Fixes #11392.

@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Jul 27, 2021
Copy link
Contributor

@spouliot spouliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vs-mobiletools-engineering-service2
Copy link
Collaborator

❌ [PR Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff

API & Generator diff

API Diff (from PR only) (no change)
Generator Diff (no change)

GitHub pages

Results can be found in the following github pages (it might take some time to publish):

Test results

2 tests failed, 116 tests passed.

Failed tests

  • monotouch-test/Mac Catalyst/Debug [dotnet]: Failed (Tests run: 2629 Passed: 2489 Inconclusive: 35 Failed: 1 Ignored: 139)
  • DotNet tests: TimedOut (Execution timed out after 30 minutes.)

Pipeline on Agent XAMBOT-1099.BigSur'
Merge ea5ef65 into edc088a

@rolfbjarne
Copy link
Member Author

Test failures are unrelated:

@rolfbjarne rolfbjarne merged commit 7986b2f into dotnet:main Jul 28, 2021
@rolfbjarne rolfbjarne deleted the dotnet-globalization-mac-catalyst branch July 28, 2021 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[dotnet] Native ICU libraries not ready for Catalyst

5 participants