[release/7.0.1xx] [tests] Ignore PassLibraryTest.PassLibraryTest on bots if PKPassLibrary.GetPasses returns null. Fixes #xamarin/maccore@2598. (#16806)

vs-mobiletools-engineering-service2 · rolfbjarne · web-flow · commit 7c4db9ebe121 · 2022-12-01T14:21:50.000+01:00
PKPassLibrary.GetPasses randomly returns null for no apparent rhyme or reason on our bots, so just ignore the test in that case. Maybe if someone can reproduce locally one day we'll be able to investigate and figure out what's happening. Fixes xamarin/maccore#2598. Backport of #16738 Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com>
diff --git a/tests/monotouch-test/PassKit/PassLibraryTest.cs b/tests/monotouch-test/PassKit/PassLibraryTest.cs
@@ -38,7 +38,11 @@ public void Defaults ()
 
 			var library = new PKPassLibrary ();
 			// not null (but empty by default) and there's no API to add them
-			Assert.NotNull (library.GetPasses (), "GetPasses");
+			var passes = library.GetPasses ();
+			if (passes is null)
+				TestRuntime.IgnoreInCI ("GetPasses () seems to randomly return null on our bots.");
+			// If the following assert fails for you locally, please investigate! See https://github.com/xamarin/maccore/issues/2598.
+			Assert.NotNull (passes, "GetPasses - if this assert fails for you locally, please investigate! See https://github.com/xamarin/maccore/issues/2598.");
 
 			using (var url = PassTest.GetBoardingPassUrl ()) {
 #if __MACCATALYST__
