Skip to content

Upgrade macos image to 11#271

Merged
MichalStrehovsky merged 1 commit intoobjwriter/12.xfrom
MichalStrehovsky-patch-2
Sep 8, 2022
Merged

Upgrade macos image to 11#271
MichalStrehovsky merged 1 commit intoobjwriter/12.xfrom
MichalStrehovsky-patch-2

Conversation

@MichalStrehovsky
Copy link
Member

10.15 got deprecated.

10.15 got deprecated.
@am11
Copy link
Member

am11 commented Sep 8, 2022

Already covered it in #185. Can you please merge that PR?

@MichalStrehovsky
Copy link
Member Author

Already covered it in #185. Can you please merge that PR?

The CI in this repo is just a build - it doesn't test anything. I want to get an objwriter package out that we can test in the runtime repo. The official build with Filip's change failed because of the brownout.

I don't want to conflate #269 with your PR because if we hit a snag in the runtime repo I won't know which PR to blame.

@MichalStrehovsky MichalStrehovsky merged commit cb1c615 into objwriter/12.x Sep 8, 2022
@MichalStrehovsky MichalStrehovsky deleted the MichalStrehovsky-patch-2 branch September 8, 2022 06:30
@am11
Copy link
Member

am11 commented Sep 8, 2022

I don't want to conflate #269 with your PR because if we hit a snag in the runtime repo I won't know which PR to blame.

Sure. But it is not possible to use objwriter on osx-arm64 with #269, without #185. It is possible the other way around. ;)

@MichalStrehovsky
Copy link
Member Author

Sure. But it is not possible to use objwriter on osx-arm64 with #269, without #185. It is possible the other way around. ;)

Right, but it's possible to break non-osx-arm64 platforms with either of the PRs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants