Add separate step for marking public surface of libraries#793
Closed
sbomer wants to merge 1 commit intodotnet:masterfrom
Closed
Add separate step for marking public surface of libraries#793sbomer wants to merge 1 commit intodotnet:masterfrom
sbomer wants to merge 1 commit intodotnet:masterfrom
Conversation
- ResolveFromAssemblyStep no longer deals with visibility - '-r' instead uses MarkPublicFromAssemblyStep - '-r' assemblies are tracked as public in the LinkContext, and they aren't optimized in MarkStep. - Currently if the same assembly is passed via '-r' and '-a', it will still be considered a public assembly by MarkStep and not optimized. This probably shouldn't be a valid combination of parameters in the first place. - MarkPublicFromAssemblyStep does a combination of what ResolveFromAssemblyStep and MarkStep used to do. It was created by copying over sources from those two steps, and unifying some of the overlapping logic (for example the Initialize* logic from MarkStep and the Mark* logic from ResolveFromAssemblyStep). It hasn't yet been pruned, so still has unnecessary optimizations from MarkStep.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@marek-safar I'm investigating the approach we discussed of creating a new step to replace ResolveFromAssemblyStep and MarkStep, and wanted to share what it looks like so far.
aren't optimized in MarkStep.
still be considered a public assembly by MarkStep and not
optimized. This probably shouldn't be a valid combination of
parameters in the first place.
ResolveFromAssemblyStep and MarkStep used to do. It was created by
copying over sources from those two steps, and unifying some of the
overlapping logic (for example the Initialize* logic from MarkStep
and the Mark* logic from ResolveFromAssemblyStep). It hasn't yet
been pruned, so still has unnecessary optimizations from MarkStep.