Skip to content

Upgrade MSBuild ref and downgrade global.json#3089

Merged
agocke merged 1 commit intodotnet:release/6.0.xfrom
agocke:upgrade-msbuild-ref
Oct 27, 2022
Merged

Upgrade MSBuild ref and downgrade global.json#3089
agocke merged 1 commit intodotnet:release/6.0.xfrom
agocke:upgrade-msbuild-ref

Conversation

@agocke
Copy link
Member

@agocke agocke commented Oct 27, 2022

The official build has an old version of MSBuild so we can't use a new version of MSBuild. However, we do need a higher version of MSBuild as our ref for the tasks, so this also upgrades the version of MSBuild.

The two changes are technically separate, even though they both involve MSBuild.

The official build has an old version of MSBuild so we can't use
a new version of MSBuild. However, we do need a higher version of MSBuild
as our ref for the tasks, so this also upgrades the version of MSBuild.

The two changes are technically separate, even though they both involve
MSBuild.
@agocke agocke requested a review from sbomer October 27, 2022 20:37
@agocke agocke requested a review from marek-safar as a code owner October 27, 2022 20:37
@agocke agocke removed the request for review from marek-safar October 27, 2022 20:37
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

It might also be possible to fix it by adding xcopy-msbuild like I did in #2945.

Where is the requirement to upgrade the MSBuild reference version coming from?

@agocke
Copy link
Member Author

agocke commented Oct 27, 2022

Ah, yeah, I could do that. Right now I'm not sure it's necessary, but that will be my next solution if I run into more problems.

@agocke agocke merged commit 997d750 into dotnet:release/6.0.x Oct 27, 2022
@agocke agocke deleted the upgrade-msbuild-ref branch October 27, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants