Skip to content

Upgrade transitive references to avoid warnings#3084

Merged
agocke merged 2 commits intodotnet:release/6.0.xfrom
agocke:update-dependencies
Oct 26, 2022
Merged

Upgrade transitive references to avoid warnings#3084
agocke merged 2 commits intodotnet:release/6.0.xfrom
agocke:update-dependencies

Conversation

@agocke
Copy link
Member

@agocke agocke commented Oct 25, 2022

There are official build warnings because some references are too old. This is an attempt to bring them all up to date.

@agocke agocke requested a review from marek-safar as a code owner October 25, 2022 19:33
@agocke agocke marked this pull request as draft October 25, 2022 19:53
@agocke agocke force-pushed the update-dependencies branch from 4a1835d to 4191a04 Compare October 25, 2022 20:18
@agocke agocke force-pushed the update-dependencies branch from 4191a04 to 8296efa Compare October 25, 2022 20:19
@agocke agocke marked this pull request as ready for review October 26, 2022 01:22
@agocke agocke requested a review from sbomer October 26, 2022 01:23
@agocke
Copy link
Member Author

agocke commented Oct 26, 2022

@sbomer Could you take a look at this?

Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

<MicrosoftCodeAnalysisVersion>3.10.0-2.final</MicrosoftCodeAnalysisVersion>
<MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>1.0.1-beta1.*</MicrosoftCodeAnalysisCSharpAnalyzerTestingXunitVersion>
<MicrosoftCodeAnalysisBannedApiAnalyzersVersion>3.3.2</MicrosoftCodeAnalysisBannedApiAnalyzersVersion>
<MicrosoftNETTestSdkVersion>16.11.0</MicrosoftNETTestSdkVersion>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this because the version we were using was incompatible with the new nunit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the versions that's causing the warnings.

@agocke agocke merged commit de816ce into dotnet:release/6.0.x Oct 26, 2022
@agocke agocke deleted the update-dependencies branch October 26, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants