[release/6.0.2xx] Fix analyzer nullref on assembly attribute #2530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The analyzer runs for property assignment operations, including those in attributes. To check whether the property assignment should warn, we look for RUC on the containing symbol. However, assembly-level attributes are contained in the global namespace, which has a null containing type.
Member
|
This will have to go through QB approval. Could you make the change in main first? I'm not sure it will meet the bar without a customer report. |
vitek-karas
approved these changes
Jan 21, 2022
jeffschwMSFT
approved these changes
Jan 29, 2022
Member
jeffschwMSFT
left a comment
There was a problem hiding this comment.
Approved. Please take for consideration in 6.0.2xx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analyzer runs for property assignment operations, including those in
attributes. To check whether the property assignment should warn, we
look for RUC on the containing symbol. However, assembly-level attributes
are contained in the global namespace, which has a null containing type.
Customer Impact
Assembly-level attribute with property assignment causes a crash in the RequiresAttribute analyzers. #2563 hits what is likely this issue.
Testing
Unit tests added in this change. This was originally discovered as part of running the analyzer over the existing linker tests as part of #2523.
Risk
Very low risk - the change adds an extra null check without impacting other code paths.