Skip to content

[generator] Output correct formatting for binding warnings. #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonpryor merged 1 commit into from
Oct 15, 2020
Merged

[generator] Output correct formatting for binding warnings. #737

jonpryor merged 1 commit into from
Oct 15, 2020

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Oct 14, 2020 •
edited
Loading

In d664e90 we refactored some output regarding binding warning messages in order to better support localization. Unfortunately this refactoring left out a period between some type and member names:

warning BG8700: Unknown return type 'Android.App.Admin.AppOpsManagerMode' for member 'Android.App.AppOpsManagerUnsafeCheckOp (java.lang.String, int, java.lang.String)'.

Android.App.AppOpsManagerUnsafeCheckOp should be Android.App.AppOpsManager.UnsafeCheckOp instead.

@jpobst jpobst marked this pull request as ready for review October 14, 2020 18:34
@jonpryor jonpryor merged commit 9c73dbf into master Oct 15, 2020
@jonpryor jonpryor deleted the context-output branch October 15, 2020 14:54
@jpobst jpobst added this to the 11.1 (16.9 / 8.9) milestone Nov 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

11.2 (16.9 / 8.9)

Development

Successfully merging this pull request may close these issues.

3 participants

@jpobst @jonpryor