Fix projects with double S.D.G imports #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ellerbach
approved these changes
Sep 3, 2021
Member
Ellerbach
left a comment
There was a problem hiding this comment.
Thanks for fixing it! Looking forward to have it merged!
|
Hello @joperezr! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes, a condition that will be fulfilled in about 55 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Ellerbach reported today that VS had yellow warning signs in references in most of the binding projects.
The reason why that was happening is because System.Device.Gpio project reference was added twice to all bindings, one global import, and one individual import per project. This PR is removing all of the individual imports in favor of just keeping the one global import, and I have validated that after doing this, the problem no longer repros:
Changes to projects where made using a small program I wrote which uses the MSBuild project model to make the changes, which is why most new-lines are being removed from .csprojs as a side effect.
Microsoft Reviewers: Open in CodeFlow