Skip to content

[master] Update dependencies from dotnet/toolset#6266

Merged
dotnet-maestro[bot] merged 27 commits intomasterfrom
darc-master-c64ffaaf-a759-4acb-9f72-191aa83dea03
Feb 5, 2020
Merged

[master] Update dependencies from dotnet/toolset#6266
dotnet-maestro[bot] merged 27 commits intomasterfrom
darc-master-c64ffaaf-a759-4acb-9f72-191aa83dea03

Conversation

@dotnet-maestro
Copy link

@dotnet-maestro dotnet-maestro bot commented Jan 30, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/toolset

  • Subscription: 7bfd2e5d-8f3f-48b5-3da6-08d6ba11e0be
  • Build: 20200204.4
  • Date Produced: 2/4/2020 2:16 PM
  • Commit: faf758fade6e4333b366c433f543b997e9394f83
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.Dotnet.Toolset.Internal -> 5.0.100-alpha.1.20104.4

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Microsoft.DotNet.Common.ItemTemplates -> 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
  • Microsoft.DotNet.MSBuildSdkResolver -> 5.0.100-alpha.1.20104.4 (parent: Microsoft.Dotnet.Toolset.Internal)

…0128.2

- Microsoft.NETCore.App.Host.win-x64 - 5.0.0-alpha.1.20078.2
- Microsoft.NETCore.App.Internal - 5.0.0-alpha.1.20078.2
- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.20078.2
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.20078.2
- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.20078.2

Dependency coherency updates

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.20078.2 (parent: Microsoft.NetCore.App.Internal)
…0130.4

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20080.4

Dependency coherency updates

- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20080.4 (parent: Microsoft.Dotnet.Toolset.Internal)
@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Jan 30, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Darwin Build_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0130.6

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20080.6

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20080.6 (parent: Microsoft.Dotnet.Toolset.Internal)
…0130.10

- Microsoft.NETCore.App.Host.win-x64 - 5.0.0-alpha.1.20080.10
- Microsoft.NETCore.App.Internal - 5.0.0-alpha.1.20080.10
- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.20080.10
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.20080.10
- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.20080.10

Dependency coherency updates

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.20080.10 (parent: Microsoft.NetCore.App.Internal)
…0131.1

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20081.1

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20081.1 (parent: Microsoft.Dotnet.Toolset.Internal)
…0131.3

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20081.3

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20081.3 (parent: Microsoft.Dotnet.Toolset.Internal)
…0131.2

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20081.2

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20081.2 (parent: Microsoft.Dotnet.Toolset.Internal)
…0131.4

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20081.4

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20081.4 (parent: Microsoft.Dotnet.Toolset.Internal)
…0131.5

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20081.5

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20081.5 (parent: Microsoft.Dotnet.Toolset.Internal)
…0201.1

- Microsoft.NETCore.App.Host.win-x64 - 5.0.0-alpha.1.20101.1
- Microsoft.NETCore.App.Internal - 5.0.0-alpha.1.20101.1
- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.20101.1
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.20101.1
- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.20101.1

Dependency coherency updates

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.20101.1 (parent: Microsoft.NetCore.App.Internal)
…0201.1

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20101.1

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20101.1 (parent: Microsoft.Dotnet.Toolset.Internal)
…0201.2

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20101.2

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20080.1 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
…0201.3

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20101.3

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20101.3 (parent: Microsoft.Dotnet.Toolset.Internal)
…0201.4

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20101.4

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20101.4 (parent: Microsoft.Dotnet.Toolset.Internal)
…0201.3

- Microsoft.NETCore.App.Host.win-x64 - 5.0.0-alpha.1.20101.3
- Microsoft.NETCore.App.Internal - 5.0.0-alpha.1.20101.3
- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.20101.3
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.20101.3
- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.20101.3

Dependency coherency updates

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.20101.3 (parent: Microsoft.NetCore.App.Internal)
…0202.3

- Microsoft.NETCore.App.Host.win-x64 - 5.0.0-alpha.1.20102.3
- Microsoft.NETCore.App.Internal - 5.0.0-alpha.1.20102.3
- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.20102.3
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.20102.3
- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.20102.3

Dependency coherency updates

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.20102.3 (parent: Microsoft.NetCore.App.Internal)
@wtgodbe
Copy link
Member

wtgodbe commented Feb 3, 2020

@wli3 @nguerrera @dsplaisted is someone looking at this?

@wtgodbe
Copy link
Member

wtgodbe commented Feb 3, 2020

It_errors_when_publishing_single_file_app_without_rid

The command output did not contain expected result: NETSDK1097: It is not supported to publish an application to a single-file without specifying a RuntimeIdentifier. Please either specify a RuntimeIdentifier or set PublishSingleFile to false.\r\n\r\nFile Name: D:\a\1\s\artifacts\bin\redist\Release\dotnet-with-previous-runtimes\dotnet\r\nArguments: msbuild /t:Publish D:\a\1\s\artifacts\tmp\Release\dotnetSdkTests\GetPublishCom---86179EA5\HelloWorldWithSubDirs.csproj /restore /p:PublishSingleFile=true\r\nExit Code: 1\r\nStdOut:\r\n\r\nStdErr:\r\nSystem.TypeLoadException: Could not load type 'System.Resources.ResourceManager' from assembly 'System.Runtime, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.\r\n at Microsoft.DotNet.Cli.Utils.LocalizableStrings.get_DotnetCliHomeUsed() in //artifacts/obj/Microsoft.DotNet.Cli.Utils/Release/netcoreapp5.0/Microsoft.DotNet.Cli.Utils.LocalizableStrings.cs:line 61\r\n at Microsoft.DotNet.Cli.Program.ReportDotnetHomeUsage(IEnvironmentProvider provider) in //src/dotnet/Program.cs:line 241\r\n at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient) in //src/dotnet/Program.cs:line 156\r\n at Microsoft.DotNet.Cli.Program.Main(String[] args) in //src/dotnet/Program.cs:line 47\r\n\r\n

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Feb 3, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Darwin Build_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dsplaisted
Copy link
Member

@wtgodbe I will look at it

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Feb 3, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Darwin Build_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@nguerrera nguerrera added this to the 5.0.1xx milestone Feb 3, 2020
…0203.2

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20103.2

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20103.2 (parent: Microsoft.Dotnet.Toolset.Internal)
@dsplaisted
Copy link
Member

@wtgodbe It looks like the tests are failing with this:

System.TypeLoadException: Could not load type 'System.Resources.ResourceManager' from assembly 'System.Runtime, Version=5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
   at Microsoft.DotNet.Cli.Utils.LocalizableStrings.get_DotnetCliHomeUsed() in /_/artifacts/obj/Microsoft.DotNet.Cli.Utils/Release/netcoreapp5.0/Microsoft.DotNet.Cli.Utils.LocalizableStrings.cs:line 61
   at Microsoft.DotNet.Cli.Program.ReportDotnetHomeUsage(IEnvironmentProvider provider) in /_/src/dotnet/Program.cs:line 241
   at Microsoft.DotNet.Cli.Program.ProcessArgs(String[] args, ITelemetry telemetryClient) in /_/src/dotnet/Program.cs:line 156
   at Microsoft.DotNet.Cli.Program.Main(String[] args) in /_/src/dotnet/Program.cs:line 47

Did ResourceManager move recently, or did something else change with it?

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Feb 4, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Darwin Build_Release), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0203.10

- Microsoft.NETCore.DotNetHostResolver - 5.0.0-alpha.1.20103.10
- Microsoft.NETCore.App.Host.win-x64 - 5.0.0-alpha.1.20103.10
- Microsoft.NETCore.App.Runtime.win-x64 - 5.0.0-alpha.1.20103.10
- Microsoft.NETCore.App.Ref - 5.0.0-alpha.1.20103.10
- Microsoft.NETCore.App.Internal - 5.0.0-alpha.1.20103.10

Dependency coherency updates

- Microsoft.NETCore.Platforms - 5.0.0-alpha.1.20103.10 (parent: Microsoft.NetCore.App.Internal)
…0204.1

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20104.1

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20104.1 (parent: Microsoft.Dotnet.Toolset.Internal)
…0204.3

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20104.3

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20104.3 (parent: Microsoft.Dotnet.Toolset.Internal)
…0204.2

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20104.2

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20104.2 (parent: Microsoft.Dotnet.Toolset.Internal)
…0204.4

- Microsoft.Dotnet.Toolset.Internal - 5.0.100-alpha.1.20104.4

Dependency coherency updates

- Microsoft.DotNet.Common.ItemTemplates - 5.0.0-alpha1.20101.2 (parent: Microsoft.Dotnet.Toolset.Internal)
- Microsoft.DotNet.MSBuildSdkResolver - 5.0.100-alpha.1.20104.4 (parent: Microsoft.Dotnet.Toolset.Internal)
@wtgodbe
Copy link
Member

wtgodbe commented Feb 4, 2020

@dsplaisted yeah, this is related to dotnet/runtime@099a512#diff-1cf0c3d418c406375c5319a82bf2c96f. The fix is to either get a new SDK (which you can't really do in this repo), or update your FrameworkReferences to reference the runtime at the version in versions.props rather than what's in the SDK (see https://github.com/dotnet/extensions/blob/ccd42d9b2341bedd3e652bb2cab1cca72431a8fd/eng/Workarounds.AfterArcade.targets#L12-L17). Without that workaround, you'd theoretically break anytime runtime changes surface area, since you'd be building against the new runtime but running against the old. The same would be true for the Asp.Net runtime this repo as well, I guess

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Feb 4, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Darwin Build_Release), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

This updates the dotnet/runtime dependencies and should fix the failures
@dsplaisted
Copy link
Member

@wtgodbe I pushed some changes that I hope will fix this. I think the real problem was that this repo didn't have the latest runtime, as #6262 wasn't merged. I merged those changes into this PR and applied a workaround for the test timeout. 🤞

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Feb 4, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Standard Merge Policies Unsuccessful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Darwin Build_Release), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dsplaisted
Copy link
Member

@sbomer I'm getting ILLINK failures on this PR:

ILLINK : error : Unknown option: `l'

Did something change recently with ILLINK? Could different pieces be out of sync with this PR?

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Feb 4, 2020

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • Waiting on checks: .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Arm64_Debug), .NET Core core-sdk CI (build Linux Build_Arm_Debug), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_arm), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86), .NET Core core-sdk CI (build Darwin Build_Release), .NET Core core-sdk CI
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

Waiting for codeflow from dotnet/sdk#10602
@dsplaisted
Copy link
Member

I'm disabling the ILLINK tests until the fix from dotnet/sdk#10602 flows through in order to unblock this PR.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented Feb 4, 2020

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: .NET Core core-sdk CI, .NET Core core-sdk CI (build Linux Build_LinuxPortable_Release_x64), .NET Core core-sdk CI (build Linux Build_Linux_musl_Debug_x64), .NET Core core-sdk CI (build Linux Build_Arm64_Debug), .NET Core core-sdk CI (build Linux Build_Arm_Debug), .NET Core core-sdk CI (build Linux Build_Rhel_7_2_Release_x64), .NET Core core-sdk CI (build Darwin Build_Release), .NET Core core-sdk CI (build Linux Build_Debian_Stretch_Debug_x64), .NET Core core-sdk CI (build Linux Build_CentOS_7_1_Debug_x64), .NET Core core-sdk CI (build Linux Build_Fedora_29_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_arm), .NET Core core-sdk CI (build Linux Build_Ubuntu_18_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Release_x64), .NET Core core-sdk CI (build Linux Build_Ubuntu_16_04_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_ES_Debug_x64), .NET Core core-sdk CI (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@dotnet-maestro dotnet-maestro bot merged commit 5dbf6ae into master Feb 5, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-c64ffaaf-a759-4acb-9f72-191aa83dea03 branch February 5, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants