Enable source-build prebuilts detection #16320
Conversation
|
Shouldn't this be fixing #16319, not microsoft/vstest#4405? |
| <UsagePattern IdentityGlob="System.Security.Cryptography.Cng/5.0.0-preview.3.20214.6" /> | ||
| <UsagePattern IdentityGlob="System.Security.Cryptography.Pkcs/5.0.0-preview.3.20214.6" /> | ||
|
|
||
| <!-- These are coming in via runtime but the source-build infra isn't able to automatically pick up the right intermediate. --> |
There was a problem hiding this comment.
Is there an issue for this that can be referenced?
There was a problem hiding this comment.
Is there an issue for this that can be referenced?
I'm not sure - I copied the comment from this PR by @mmitche - dotnet/aspnetcore#47894
| <UsagePattern IdentityGlob="System.Security.Cryptography.Cng/5.0.0-preview.3.20214.6" /> | ||
| <UsagePattern IdentityGlob="System.Security.Cryptography.Pkcs/5.0.0-preview.3.20214.6" /> | ||
|
|
||
| <!-- These are coming in via runtime but the source-build infra isn't able to automatically pick up the right intermediate. --> |
There was a problem hiding this comment.
Would these be resolved if the runtime intermediate was pulled in? I see the runtime dependency is using the SourceBuildTarball metadata instead of SourceBuild. The tarball attribute doesn't pull down the intermediate during the repo SB legs. It was a temporary attribute for use when a repo didn't produce an intermediate. dotnet/source-build#3351 tracks removing all usages.
There was a problem hiding this comment.
Yeah - updating - only one remains, that is also present in this PR: dotnet/aspnetcore#47894
| Once that's fixed, NuGet package version should be updated to newest, and intermediate product dependency | ||
| added to Version.Details.xml | ||
| --> | ||
| <UsagePattern IdentityGlob="NuGet.Common/*5.8.0*" /> |
There was a problem hiding this comment.
FYI, SDK uses a NuGet.* pattern - https://github.com/dotnet/sdk/blob/main/eng/SourceBuildPrebuiltBaseline.xml#L6
There was a problem hiding this comment.
FYI, SDK uses a NuGet.* pattern - https://github.com/dotnet/sdk/blob/main/eng/SourceBuildPrebuiltBaseline.xml#L6
I see - I used aspnetcore implementation as a model: https://github.com/dotnet/aspnetcore/blob/28602638d11f01a0e20a3d0a0aa1f3a9a84406d6/eng/SourceBuildPrebuiltBaseline.xml#L6-L10
Both options have their pros and cons - if we should adopt a single model, this PR should follow it.
There was a problem hiding this comment.
Agreed both patterns have their pros and cons. It's not a big deal as this is temporary until the nuget intermediate is produced.
Fixes: #16319
### Summary of the changes
The goal is to enable per-repo source-build to detect prebuilt packages.
Currently, all prebuilts are excluded due to known issues called out in comments.