Add KnownWebAssemblySdkPack to GenerateBundledVersions for .NET 6 and 7#16159
Merged
Add KnownWebAssemblySdkPack to GenerateBundledVersions for .NET 6 and 7#16159
Conversation
…package Microsoft.NET.Sdk.WebAssembly.Pack for .NET 6 and 7.
This was referenced Apr 19, 2023
marcpopMSFT
reviewed
Apr 19, 2023
| <_NET70RuntimePackVersion>7.0.$(VersionFeature70)</_NET70RuntimePackVersion> | ||
| <_NET70TargetingPackVersion>7.0.$(VersionFeature70)</_NET70TargetingPackVersion> | ||
| <_NET70ILLinkPackVersion>7.0.100-1.23062.2</_NET70ILLinkPackVersion> | ||
| <_NET70WebAssemblyPackVersion>$(MicrosoftNETCoreAppRuntimePackageVersion)</_NET70WebAssemblyPackVersion> |
Member
There was a problem hiding this comment.
You want the 70 webassembly pack version to be the current net8 version number? Also, is 60 meant to be the same as 70?
Member
There was a problem hiding this comment.
Given that there is currently only one version of this package and as far as I know it handles the downlevels correctly I think for the moment we should just make sure there is just a definition that will match for the supported targets.
lewing
approved these changes
Apr 20, 2023
Member
lewing
left a comment
There was a problem hiding this comment.
We definitely need the settings so I think this is fine for the moment and we can refine it in the followups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add KnownWebAssemblySdkPack to GenerateBundledVersions pointing to a package
Microsoft.NET.Sdk.WebAssembly.Packfor .NET 6 and 7.For .NET 5 blazor has a completely separate targets which don't go through Wasm SDK.
At the moment it points to a "current" version. When make a stable and backward compatible release the version should split the same as for ILLinkPack.