Poison work - reordering and exclusion of non-shipping packages#15347
Poison work - reordering and exclusion of non-shipping packages#15347NikolaMilosavljevic merged 4 commits intodotnet:mainfrom
Conversation
|
Runtime patch backport: dotnet/runtime#81180 |
4d04c83 to
a506f64
Compare
| { | ||
| return NonShippingPackagesListFiles | ||
| .SelectMany(item => File.ReadAllLines(item.ItemSpec)) | ||
| .Distinct(); |
There was a problem hiding this comment.
I think you want to include a ToList() invocation here otherwise the entire linq query is re-evaluated on every iteration of the while loop in GetPoisonedFiles
There was a problem hiding this comment.
Fixed in commit 4.
| Date: Tue, 24 Jan 2023 18:03:12 +0000 | ||
| Subject: [PATCH] Allow source-build to set UsingToolMicrosoftNetCompilers | ||
| property | ||
|
|
There was a problem hiding this comment.
Please include the following comment. This makes it easier to manage patches.
backport: https://github.com/dotnet/runtime/pull/81180
There was a problem hiding this comment.
Fixed in commit 4.
| @@ -0,0 +1,100 @@ | |||
| <!-- Licensed to the .NET Foundation under one or more agreements. The .NET Foundation licenses this file to you under the MIT license. --> | |||
There was a problem hiding this comment.
Please open a backport PR for the ArcadeOverrides and link to this PR.
There was a problem hiding this comment.
Backport of arcade overrides: dotnet/arcade#12326
| Lines="@(IntermediateNonShippingNupkgFile->'%(Filename)%(Extension)')" | ||
| Overwrite="true" /> | ||
|
|
||
| <ItemGroup> |
There was a problem hiding this comment.
I still don't understand what this item group does. Can you help me understand what it is needed for? Who consumes the Content?
There was a problem hiding this comment.
Nuget packaging consumes Content items. This is the same as old code, above, in GetSupplementalIntermediateNupkgManifest target.
There was a problem hiding this comment.
Ok, that is what I was missing. Thanks for explaining.
|
WOO! |
Fixes the following issues:
dotnet/source-build#2997
dotnet/source-build#2579
dotnet/source-build#2577
dotnet/source-build#2576
dotnet/source-build#3000
Also removes most of poisoned artifacts, by reordering repo build -
runtimewill now build beforeroslynandlinkerrepos.New patch is required for
runtimerepo. Patch backport is also in progress: dotnet/runtime#81180Backport of arcade overrides: dotnet/arcade#12326