Apply RID override behaviour from runtime to aspnetcore/installer#15143
Merged
Conversation
MichaelSimons
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
./build.shon a Mac creates a runtime pack with a RID ofosx-x64due to an OS override in the proj file. Later, aspnetcore tries to restore a runtime but does not override the RID - it searches for osx.12-x64 and fails.This PR attempts to unify RID override behaviour around how it's done in runtime. The Windows and FreeBSD overrides are not tested, but should be consistent (I expect they currently fail in the same way macOS does)
Closes: dotnet/source-build#3151