Eliminate MicrosoftCodeAnalysis prebuilts in runtime#14844
Merged
MichaelSimons merged 3 commits intodotnet:mainfrom Oct 31, 2022
Merged
Eliminate MicrosoftCodeAnalysis prebuilts in runtime#14844MichaelSimons merged 3 commits intodotnet:mainfrom
MichaelSimons merged 3 commits intodotnet:mainfrom
Conversation
lbussell
approved these changes
Oct 31, 2022
Co-authored-by: Logan Bussell <loganbussell@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are MicrosoftCodeAnalysis prebuilts in runtime because
MicrosoftCodeAnalysisVersion_4_4andMicrosoftCodeAnalysisVersion_LatestVSdo not reference the source-built versions. I added ExtraPackageVersionPropsPackageInfo for these. Because of that change, format and installers encountered CS9057 which I suppressed.Because of the need to nowarn CS9057, I took the time to add infra to suppress warnings via the source-build repo projects and utilized it to replace the remaining nowarn patches.