[release/7.0.1xx] Fix --use-current-runtime for linux-musl-arm64#14637
Closed
am11 wants to merge 5 commits intodotnet:release/7.0.1xxfrom
Closed
[release/7.0.1xx] Fix --use-current-runtime for linux-musl-arm64#14637am11 wants to merge 5 commits intodotnet:release/7.0.1xxfrom
am11 wants to merge 5 commits intodotnet:release/7.0.1xxfrom
Conversation
am11
commented
Oct 1, 2022
Member
|
This is about ensuring The fix looks good for Microsoft's portable builds. We also need to look at making it work for source-build .NET where |
Member
Author
|
In some places, we are using conditions like: <OSIdentifier Condition="$(RuntimeIdentifier.StartsWith('linux-musl')) OR $(RuntimeIdentifier.StartsWith('alpine'))">linux-musl</OSIdentifier>Though it's not ideal (for other musl-based distros), it will cover the officially supported platform matrix. |
Member
|
@MichaelSimons is this for rtm? |
Member
|
Closing in favor of #14647 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @tmds