Update ulimit#12576
Conversation
| dockerbuild $args | ||
| else | ||
| $DIR/run-build.sh $args | ||
| sudo $DIR/run-build.sh $args |
There was a problem hiding this comment.
Probably merits a similar comment to the other file so folks know why you did it, possibly a link to the tracking issue so it can be reverted if/when this gets addressed by 1ES
|
Is defaulting to sudo a good idea? That means everyone trying to build installer needs to have root on their machine. Non root users can't even build it.. Worse, now running as root, the build downloads a whole bunch of files and binaries from the network. Then the build executes all those things as root. This also makes the source-build dev experience much worse. The build starts off (because I provide my sudo password), then the sudo timeout hits, and the build hangs building at some point asking me to enter my sudo password again. Maybe this is a workaround for CI, perhaps it should probe for the CI environment and only then do it? |
A fair point but also it's worth reminding ourselves that users with default ulimit -n values are going to hit the same thing just trying to test locally, so it may be worth trying to make the tests fit within a typical limit too |
|
This also broke all the official builds as we lost the ambient AzDO environment variables in the build scripts. I think we should revert. |
Fixes #12575
See also https://github.com/dotnet/core-eng/issues/14808