Only add intermediates to previous source-built archive#12574
Closed
MichaelSimons wants to merge 1 commit into
Closed
Only add intermediates to previous source-built archive#12574MichaelSimons wants to merge 1 commit into
MichaelSimons wants to merge 1 commit into
Conversation
MichaelSimons
commented
Nov 1, 2021
| Lines="$(PackageVersionsPropsContents)" | ||
| Overwrite="true" /> | ||
|
|
||
| <!-- |
Member
Author
There was a problem hiding this comment.
This logic was moved to the end of the target to keep the previous source-built logic grouped.
Member
Author
|
Closing as this work has stalled and it currently not a top priority. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#2262 by only including the intermediates in the archive. This is the preferred long-term approach as there will be dependencies on the intermediates in the future. This reduces the archive by ~1 GB.
Previously previous source-built included the text-only prebuilts created as part of the tarball creation process. These are no longer included as they are not part of any intermediate.
dotnet/source-build#2357 and dotnet/source-build#2472 are remaining issues that will reduce the archive size further.