[release/5.0.2xx] Backport x64 on ARM64 installer changes #12494
Merged
ericstj merged 3 commits intodotnet:release/5.0.2xxfrom Oct 25, 2021
Merged
[release/5.0.2xx] Backport x64 on ARM64 installer changes #12494ericstj merged 3 commits intodotnet:release/5.0.2xxfrom
ericstj merged 3 commits intodotnet:release/5.0.2xxfrom
Conversation
* Remove writing InstallLocation from SDK, it will be handled by host * Update WiX to signed build (dotnet#12078) # Conflicts: # eng/Versions.props # src/finalizer_shim/finalizer_shim.csproj * Update WiX to 3.14.0.5722 (dotnet#12252) * Add installation checks to prevent install on ARM64 * Update wording of blockers * Ensure we allow specifying DOTNETALLOWINSTALLONARM64 Co-authored-by: Jacques Eloff <joeloff@users.noreply.github.com>
joeloff
approved these changes
Oct 22, 2021
Member
joeloff
left a comment
There was a problem hiding this comment.
Do we need to fix up the final screen here to remove the reporting of DOTNETHOME or is that already part of 5.0.2?
Member
Author
We don't support installing the SDK ARM64 downlevel so that fix was never ported. |
Member
Author
|
Approved over mail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer Impact
Customers cannot install the 3.1 SDK nor 5.0 SDK on ARM64 machines. This was an intentional decision during our first wave of changes. We would like a call on adjusting that.
We would like to consider a change that would permit installation of the 3.1 x86 SDK, the 5.0 x86 and Arm64 SDK on Arm64 machines.
Testing
Manual build of bundle to validate conditions.
Risk
Low, but schedule risk to 3.1/5.0 if we take the change. Changes are only to installer so build impact/time is low but it will cause a delay.