Skip to content

[6.0.1xx] dotnet/arcade: Disable Workloads WiX dependency in source-build to remove prebuilt#12290

Merged
dagood merged 2 commits intodotnet:release/6.0.1xxfrom
dagood:rm-wix
Oct 11, 2021
Merged

[6.0.1xx] dotnet/arcade: Disable Workloads WiX dependency in source-build to remove prebuilt#12290
dagood merged 2 commits intodotnet:release/6.0.1xxfrom
dagood:rm-wix

Conversation

@dagood
Copy link
Member

@dagood dagood commented Oct 11, 2021

Apply dotnet/arcade#8016 as a patch:

For dotnet/arcade#8014 (see issue for details/caveats)

After setting up the csproj, my process was to run a build with IncludeWiX=false, see which .cs files caused failures, change the extension to .wix.cs, and repeat. It seems to ended up pretty reasonably--at least, the files all seem to have to do with MSIs and not anything that could be useful for Linux. 😄

I'm running a 6.0 source-build with this change as a patch file to make sure it doesn't cause a downstream build error.

The intent is that this change doesn't affect "normal" builds at all.

Formatted with git format-patch --zero-commit --no-signature -1 for low diff on changes. (I found a few new flags while working on patches elsewhere: commit is now zeroed out, and the Git version is no longer at the end of the file.)

Local build is still running, but it did remove the prebuilt in dotnet/arcade and the dotnet/runtime portable build passed, so far.

@dagood
Copy link
Member Author

dagood commented Oct 11, 2021

Confirmed in the CI job artifacts that this removes the prebuilt--merging.

@dagood dagood merged commit b7df57c into dotnet:release/6.0.1xx Oct 11, 2021
@dagood dagood deleted the rm-wix branch October 11, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants