[6.0.1xx] dotnet/arcade: Disable Workloads WiX dependency in source-build to remove prebuilt#12290
Merged
dagood merged 2 commits intodotnet:release/6.0.1xxfrom Oct 11, 2021
Merged
Conversation
MichaelSimons
approved these changes
Oct 11, 2021
...urceBuild/tarball/patches/arcade/0009-Disable-Workloads-WiX-dependency-in-source-build.patch
Show resolved
Hide resolved
dseefeld
approved these changes
Oct 11, 2021
Member
Author
|
Confirmed in the CI job artifacts that this removes the prebuilt--merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply dotnet/arcade#8016 as a patch:
Formatted with
git format-patch --zero-commit --no-signature -1for low diff on changes. (I found a few new flags while working on patches elsewhere: commit is now zeroed out, and the Git version is no longer at the end of the file.)Local build is still running, but it did remove the prebuilt in dotnet/arcade and the dotnet/runtime portable build passed, so far.