[release/3.1.4xx] Backport x64 on ARM64 installer changes #12280
Merged
ericstj merged 6 commits intodotnet:release/3.1.4xxfrom Oct 11, 2021
Merged
[release/3.1.4xx] Backport x64 on ARM64 installer changes #12280ericstj merged 6 commits intodotnet:release/3.1.4xxfrom
ericstj merged 6 commits intodotnet:release/3.1.4xxfrom
Conversation
# Conflicts: # eng/Versions.props # src/finalizer_shim/finalizer_shim.csproj
NikolaMilosavljevic
approved these changes
Oct 9, 2021
ericstj
commented
Oct 11, 2021
ericstj
commented
Oct 11, 2021
joeloff
reviewed
Oct 11, 2021
sfoslund
approved these changes
Oct 11, 2021
Member
sfoslund
left a comment
There was a problem hiding this comment.
Reviewed mac side, scanned windows
joeloff
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of the following 6.0 changes to support blocking installation on ARM64, and moving product detection keys to the host installer.
This also adds installation blocks to both the MacOs and Windows installers.