Conversation
…tion message with version info + fix small grammar mistake
d68c0f7 to
393d28f
Compare
ef6b8a2 to
e477b24
Compare
baronfel
left a comment
There was a problem hiding this comment.
For the timeout exit code work, what is the error code that's returned? Do you have sample output from testing that I can see? What I'm curious about is if the user has an exit-code-based way of detecting a script timeout error vs. any other kind of error.
src/dotnet-install.ps1
Outdated
| } | ||
|
|
||
| if (![string]::IsNullOrEmpty($Version)) { | ||
| throw "Either Quality or Version option has to be specified. See https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script#:~:text=valid%20for%20Windows.)-,%2DQuality%7C%2D%2Dquality%20%3CQUALITY%3E,-Downloads%20the%20latest for details." |
There was a problem hiding this comment.
This is useful, but I don't think this anchor-syntax is available on all browsers - I believe it is only supported on chromium-based browsers. Is there a 'normal' HTML anchor on this docs page that can be used instead? If not, can we modify/work with the docs team to add something more linkable?
There was a problem hiding this comment.
I have found a better option, please take a look
src/dotnet-install.sh
Outdated
|
|
||
| if [ ! -z "$quality" ]; then | ||
| if [ ! -z "$version" ] ; then | ||
| say_err "Either Quality or Version option has to be specified. See https://docs.microsoft.com/en-us/dotnet/core/tools/dotnet-install-script#:~:text=valid%20for%20Windows.)-,%2DQuality%7C%2D%2Dquality%20%3CQUALITY%3E,-Downloads%20the%20latest for details." |
There was a problem hiding this comment.
Similar question here as for the above.
curl: (7) Failed to connect to dotnetcli.azureedge.net port 443: Connection timed out or |
Co-authored-by: Bekir Ozturk <60651445+bekir-ozturk@users.noreply.github.com>
Co-authored-by: Bekir Ozturk <60651445+bekir-ozturk@users.noreply.github.com>
…t/install-scripts into dev/ykovalova/enhancements
Uh oh!
There was an error while loading. Please reload this page.