Merge master to release/dev16.8 #9789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Yeet fx_reshaped_msbuild * Update fcs build
…9483) * Move `String.length` to the top of its module so that the `length` function is in scope * Improve performance of String.concat for arrays and lists * Make concatArray local to String.concat * Testing String.concat, make sure the new three paths are covered * Remove "foo", "bax", "bar" in tests, making them more readable Co-authored-by: Phillip Carter <pcarter@fastmail.com>
* Move `String.length` to the top of its module so that the `length` function is in scope * Using known length for mapping, and unrolling x2 to improve perf of String.mapi by 2.5x * Fix two unapparent errors in the unroll loop, fix nit on parens * Add String.mapi tests for all new unrolling corner cases, and some general ones * Add side-effect test, this would fail if sequentiality of String.mapi is broken * Remove "foo" from tests * Remove unrolling of loop in String.mapi Co-authored-by: Phillip Carter <pcarter@fastmail.com>
* Initial work to fix op_UnaryPlus witness info * Added UnaryPlusDynamic * update surface area * Only enable type provider test on net472 * Removing UnaryPlusDynamic * fixing build * fix comment * Update prim-types.fs
KevinRansom
approved these changes
Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into release/dev16.8.
git fetch --all git checkout merges/master-to-release/dev16.8 git reset --hard upstream/release/dev16.8 git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-release/dev16.8 --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.