Update .NET Framework toolset #8197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
suggested changes
Jan 14, 2020
Contributor
cartermp
left a comment
There was a problem hiding this comment.
Let's undo the whitespace change and rename the PR to "Update .NET Framework toolset" and then this is good to go
Contributor
Author
|
Whitespace reverted. |
This was referenced Jan 14, 2020
cartermp
approved these changes
Jan 14, 2020
Contributor
Author
|
Oops, I merged instead of squashed, sorry about that. |
Contributor
|
You monster. |
Contributor
|
@KevinRansom @cartermp Thanks for sorting this out! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that there has been a change to the images to use the net sdk 4.8. The build script didn't pick it up and so the tests couldn't find ildasm.exe, resulting in 217 test failures in F# QA.
This would be quite difficult to pick up locally, because most people use vs command prompts, which have a properly prepared path, also because of side by side they would likely have an old sdk. I have 3 of them 4.6.1, 4.7.2 and 4.8 on my machine right now.