CherryPick into dev15.8 (Fixes #5504 - 15.8 Internal MSBuild Error (#5557)) #5597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
2 similar comments
Contributor
Author
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
Contributor
Author
|
@dotnet-bot test Ubuntu16.04 Release_default Build please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that when we do a build in the ide we copy all of the msbuild global loggers into the project. This behavior is incorrect and causes them to be used multiple times during a build. Those global loggers are not required or in some cases not designed to be reusable in that way. Causing the internal error.
The resolution is to not use the Global Loggers in our design time build.