Ref/Span fixes (#5146) - dev15.8 branch #5218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added LimitedValFlags for PostInferenceChecks * More work * Renamed IsLimited to IsLimitedSpanLike * Don't use isByRefReturnCall in CheckExprs * Minor cleanup * Changed error message. Fixed safety rule regarding byrefs returning and passing. * Fixed an edge case with returning span. Simplified Expr.App * Cleanup * Fixed a few ref return checks. Partially handling byref of span-like types * Simplifying flags. Added CheckCall * Updated test baseline. Added several CheckCall functions * Updated baseline tests * Handling byref of span likes * Added a little bit better error msg for LByrefGet * Removed commented code * Fixed test * Fixed inability to use byref<Span<>> for delegates and slots * Minor cleanup with some comments * Few more comments * Running neg tests in core/span. Fixed bug in IsByRefLike structs with span fields * Updated baseline * Fixed more issues with slots. Simplified PermitByRefType * Added a little better error messages on spans * Fixed record construction for span likes. Fixed setting fields on mutable structs not having any rules for span likes. Updated a few error msgs. Added lots of tests. * Updated error msg on function call. Added a removed comment from previous commit. Updated baselines * Added internalTestSpanStackReferring test option * Added special handling for receivers * Fixing build * Fixing build * Fixing build * More tests, updated baseline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added LimitedValFlags for PostInferenceChecks
More work
Renamed IsLimited to IsLimitedSpanLike
Don't use isByRefReturnCall in CheckExprs
Minor cleanup
Changed error message. Fixed safety rule regarding byrefs returning and passing.
Fixed an edge case with returning span. Simplified Expr.App
Cleanup
Fixed a few ref return checks. Partially handling byref of span-like types
Simplifying flags. Added CheckCall
Updated test baseline. Added several CheckCall functions
Updated baseline tests
Handling byref of span likes
Added a little bit better error msg for LByrefGet
Removed commented code
Fixed test
Fixed inability to use byref<Span<>> for delegates and slots
Minor cleanup with some comments
Few more comments
Running neg tests in core/span. Fixed bug in IsByRefLike structs with span fields
Updated baseline
Fixed more issues with slots. Simplified PermitByRefType
Added a little better error messages on spans
Fixed record construction for span likes. Fixed setting fields on mutable structs not having any rules for span likes. Updated a few error msgs. Added lots of tests.
Updated error msg on function call. Added a removed comment from previous commit. Updated baselines
Added internalTestSpanStackReferring test option
Added special handling for receivers
Fixing build
Fixing build
Fixing build
More tests, updated baseline