Surface area test output improvements#2445
Merged
KevinRansom merged 1 commit intodotnet:masterfrom Feb 16, 2017
Merged
Conversation
Re-implemented the way the test which compares actual vs. expected surface area works, so that when they don't match exactly, the output only displays the members which don't match. The new output message also shows which members were "unexpectedly present" and "unexpectedly missing", which makes it easier to diagnose the cause of the test failure.
19 tasks
KevinRansom
approved these changes
Feb 16, 2017
Contributor
KevinRansom
left a comment
There was a problem hiding this comment.
Woot ... I love this.
Contributor
|
Check out an intentional difference in the surface area caught by this test: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-implemented the way the test which compares actual vs. expected surface area works, so that when they don't match exactly, the output only displays the members which don't match. The new output message also shows which members were "unexpectedly present" and "unexpectedly missing", which makes it easier to diagnose the cause of the test failure.