Conversation
src/FSharpSource.targets
Outdated
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(TargetFramework)'=='net40'"> | ||
| <DefineConstants>$(DefineConstants);FX_ATLEAST_45</DefineConstants> |
There was a problem hiding this comment.
Probably not at least_45, since it is supposed to run on dotnet40
| @@ -24,13 +24,6 @@ | |||
| <DefineConstants>$(DefineConstants);UITHREAD_FOR_LANGUAGESERVICE</DefineConstants> | |||
There was a problem hiding this comment.
I believe these projects are all going to go away next week, once OMAR cleans up after the roslyn changes work.
|
@dotnet-bot test this please (changed hooks) |
|
@KevinRansom A heads up that the changes delete the batch files for the "fsharp" suite (hence the 9000 line removal) I'm working out how to compile the "fsharp" suite driver code for .NET Core, When run in that mode, can invoke the .NET Core F# compiler to run most of the tests (same coverage as the FSC_CORE permutation). I'm trying to reduce the use of permutations and make things a bit more explicit. Also am trying to allow those tests to be run from the F# REPL in scripting mode, something which has worked well for F# Compiler Service testing. |
|
Also addresses #889 |
…into test-fixes-2
This is a cleanup of the "fsharp" suite, to make it simpler
Still to be finalized, submitting for more complete CI