Skip to content

Conversation

@ijklam
Copy link
Contributor

@ijklam ijklam commented May 25, 2024

Description

图片

  • Complete the parameter list of the overrided method and call base method

图片

Current questions:

  1. Cannot trigger the new completion context in many case
  • When the = expr not the last expr:
    图片

  • Inside the if .. then .. (but it can trigger if there is no then)
    图片

  • In arguments list
    图片

  • There's some thing after the operator
    图片

  1. Can only trigger completion when the caret is right after the operator, and there is a space right after the operator

图片

3. Properties cannot be distinguished from methods

图片

  1. Completions in interface implementation or obj expr will not exclude items already overrided

7. Completions in interface implementation will also give overridable members from obj

图片

8. Completions doesnot insert correct type when the parameter list containing generic

图片

  1. Extension methods from getAllSymbols maybe duplicated

图片

  1. Extension methods from getAllSymbols is not detailed

Extensions from opened namespace:
图片

Extensions from getAllSymbols:
图片

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

@github-actions
Copy link
Contributor

github-actions bot commented May 25, 2024

❗ Release notes required

@Tangent-90,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md No release notes found or release notes format is not correct
vsintegration/src docs/release-notes/.VisualStudio/17.11.md No release notes found or release notes format is not correct

@ijklam ijklam changed the title Show related completion after = or <> like C# Some auto completion improvement May 26, 2024
@ijklam ijklam changed the title Some auto completion improvement [WIP] Some auto completion improvement May 26, 2024
support static member override completion
support get completions from generic base type for interface implementation and obj expr
@ijklam
Copy link
Contributor Author

ijklam commented May 26, 2024

I think I need some help to solve these questions.

support dotnet#16562 for C# style extension method
@ijklam ijklam changed the title [WIP] Some auto completion improvement [Just for running test] Some auto completion improvement Jun 28, 2024
@ijklam ijklam closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant