Fix bug in seekReadMethodDefAsMethodDataUncached#1704
Merged
KevinRansom merged 1 commit intodotnet:masterfrom Nov 4, 2016
Merged
Fix bug in seekReadMethodDefAsMethodDataUncached#1704KevinRansom merged 1 commit intodotnet:masterfrom
KevinRansom merged 1 commit intodotnet:masterfrom
Conversation
seekReadMethodDefAsMethodDataUncached didn't honour the total parameter count of both the type object and the method object. If there was only one, then the correct result would have been achieved, but when both were specific it caused corruption of the resultant MethodData structure.
dsyme
reviewed
Nov 4, 2016
| and seekReadMethodDefAsMethodDataUncached ctxtH idx = | ||
| let ctxt = getHole ctxtH | ||
| let (_code_rva, _implflags, _flags, nameIdx, typeIdx, _paramIdx) = seekReadMethodRow ctxt idx | ||
| let nm = readStringHeap ctxt nameIdx |
Contributor
There was a problem hiding this comment.
Why was this code moved in position? I don't think it matters, but best to keep it as it was if the change isn't necessary for the fix
Contributor
|
@manofstick This fix looks sound to me. It would be good to have a test case added. I presume you need a generic method in a generic interface where the method is called and/or impemented at exactly the generic type instantiation? |
Contributor
|
@manofstick Please send a new pr with a test case. thanks for taking care of this. Kevin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #1689
seekReadMethodDefAsMethodDataUncached didn't honour the total parameter count of both the type object and the method object. If there was only one (i.e. generic parameters on either the method, or the class), then the correct result would have been achieved, but when both were specific it caused corruption of the resultant MethodData structure.