Add typeforwarders to portable and coreclr fsharp.core.dll. #1675
Merged
KevinRansom merged 2 commits intodotnet:masterfrom Oct 28, 2016
KevinRansom:typeforwards
Merged
Add typeforwarders to portable and coreclr fsharp.core.dll. #1675KevinRansom merged 2 commits intodotnet:masterfrom KevinRansom:typeforwards
KevinRansom merged 2 commits intodotnet:masterfrom
KevinRansom:typeforwards
Conversation
…te fscheck to Version: 2.6.2
Contributor
|
@KevinRansom Is there any way we can validate this, e.g. capture the set of generated type forwarders like we catch the surface area? |
Contributor
Author
|
@dsyme Not really, at least not without reading the metadata of the generated assembly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libraries built with portable versions of fsharp.core.dll that uses BigInteger were not binary compatible with each other, because different F# profiles either use the platform version of BigInteger or implement there own.
This addresses this by adding type forwarders that address the binary incompatability. It also supports libraries build with fsharp.core.dll for CLR 2.x and 3.x by typeforwarding all of the types that have been implemented in CLR 4.0.
Additionally updates fscheck to 2.6.2 since that was how I discovered it.