Merged
Conversation
Contributor
Author
|
Well, I believe this is ready for merging. It eliminates the LKG tools in favour of the current nuget packages for these various tools. That gets us closer to allowing .NET Core and cross-platform builds with these tools. |
KevinRansom
suggested changes
Oct 28, 2016
| <DefineConstants>$(DefineConstants);TODO_REWORK_SERVER</DefineConstants> | ||
| <DefineConstants>$(DefineConstants);NO_LOADER_OPTIMIZATION</DefineConstants> | ||
| <DefineConstants>$(DefineConstants);SILVERLIGHT_COMPILER_FSHARP_CORE</DefineConstants> | ||
| <DefineConstants>$(DefineConstants);NETSTANDARD1_5</DefineConstants> |
Contributor
There was a problem hiding this comment.
@dsyme , we weren't going to add features based on platform except for the existing ones net40 net45 etc, are you sure you want to bake this into the compiler source?
Contributor
Author
There was a problem hiding this comment.
We just need one of these defines since the code generated by FsSrGen for .NET Core uses #if NETSTANDARD1_5 || NETSTANDARD1_6 || ...
Contributor
|
Sounds good ... although a bit weird .... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates fslex/fsyacc/fssrgen to the latest nuget packages, rather than the ancient LKG tools.
The reason for this is to align with the packages used by FSharp.Compiler.Service, which builds both Mono and .NET Core versions on Linux
That gets us closer to allowing .NET Core and cross-platform builds with these tools.