Skip to content

Making benchmarks run on non-Windows and refresh the benchmarking guidelines #16628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
psfinaki merged 4 commits into from
Feb 5, 2024
Merged

Making benchmarks run on non-Windows and refresh the benchmarking guidelines #16628

psfinaki merged 4 commits into from
Feb 5, 2024

Conversation

@psfinaki
Copy link
Contributor

@psfinaki psfinaki commented Jan 31, 2024 •
edited
Loading

Closes #16406

This:

  • adds Linux/MacOS versions of the benchmark related scripting
  • adds info about the build script benchmarking flag
  • does minor info reshuffling
  • adds a few sample results
  • fixes links, grammar and so on

@psfinaki psfinaki requested a review from a team as a code owner January 31, 2024 14:52
@github-actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024

✅ No release notes required

vzarytovskii
vzarytovskii requested changes Jan 31, 2024
View reviewed changes
@psfinaki psfinaki requested a review from vzarytovskii January 31, 2024 15:30
vzarytovskii
vzarytovskii reviewed Jan 31, 2024
View reviewed changes
vzarytovskii
vzarytovskii reviewed Jan 31, 2024
View reviewed changes
@psfinaki psfinaki changed the title Refresh the benchmarking guidelines Making benchmarks run on non-Windows and refresh the benchmarking guidelines Jan 31, 2024
@psfinaki psfinaki requested a review from vzarytovskii February 2, 2024 14:05
@psfinaki psfinaki enabled auto-merge (squash) February 2, 2024 15:14
@psfinaki psfinaki merged commit b0d0062 into dotnet:main Feb 5, 2024
@psfinaki psfinaki deleted the docs-3 branch February 10, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baronfel baronfel baronfel left review comments

@vzarytovskii vzarytovskii vzarytovskii approved these changes

+1 more reviewer

@0101 0101 0101 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update the Benchmark README

4 participants

@psfinaki @0101 @baronfel @vzarytovskii