Facelifting FCS benchmarks #16484

psfinaki · 2024-01-03T16:05:36Z

This does some cleanup in the tests/benchmarks/FCSBenchmarks folder:

fixes compile errors in FCSSourceFiles project - the code there was forgotten to be updated in this PR
removes the NU1505 workarounds - those were added here but looks like in the meantime the original problem was fixed, the VisualFSharp.sln compiles just fine without the hack now
removes empty Benchmarks.fs file - it was forgotten to be physically removed in this PR during the cleanup
updates the ParsingTypeCheckerFs benchmark name to ParsingCheckExpressionsFsSetup - was forgotten to be updated in this PR when splitting the then-existing TypeChecker.fs
disables implicit F# core refs in some projects to avoid warnings in VS
cleans up a few code and project files

github-actions · 2024-01-03T16:06:39Z

✅ No release notes required

psfinaki added 2 commits January 3, 2024 16:27

Facelifting FCS benchmarks

245cbfb

Update FSharp.Compiler.Benchmarks.fsproj

0b4ddad

psfinaki requested a review from a team as a code owner January 3, 2024 16:05

abonie approved these changes Jan 3, 2024

View reviewed changes

T-Gro approved these changes Jan 4, 2024

View reviewed changes

T-Gro merged commit f7265bb into main Jan 4, 2024

T-Gro deleted the bench/3 branch January 4, 2024 09:43