remove outputDirectory from compile-time search paths for scripts#1606
Merged
dsyme merged 3 commits intodotnet:masterfrom Oct 13, 2016
Merged
remove outputDirectory from compile-time search paths for scripts#1606dsyme merged 3 commits intodotnet:masterfrom
dsyme merged 3 commits intodotnet:masterfrom
Conversation
Contributor
Author
|
Also remove some significant code duplication in this file that has crept in over time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing the MSBuild resolution, I came across some undocumented behaviour which we should remove.
In particular, when compiling scripts using direct invocation of "fsc.exe" (e.g. without using VisualStudio or MSBuild or --noframework) we compute this:
then add this as a DLL search location:
What does this do?
Explicit compilation of scripts is relatively rare and in any case people shouldn't be relying on behaviour that deviates so much when an explicit output file is/isn't used. Let's just remove this.