Skip to content

Adjust suggested names for union case field patterns #15989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
T-Gro merged 3 commits into from
Sep 19, 2023
Merged

Adjust suggested names for union case field patterns #15989

T-Gro merged 3 commits into from
Sep 19, 2023

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Sep 17, 2023 •
edited
Loading

Minor improvements.

[<Measure>]
type userId

type UserIdAlias = int<userId>

match Some 1<userId> with
| Some u  // <--- `userIdAlias` should be suggested here instead of `num`

@kerams kerams requested a review from a team as a code owner September 17, 2023 10:24
vzarytovskii
vzarytovskii reviewed Sep 18, 2023
View reviewed changes
psfinaki
psfinaki approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@psfinaki psfinaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@vzarytovskii vzarytovskii enabled auto-merge (squash) September 18, 2023 13:12
auto-merge was automatically disabled September 18, 2023 14:39

Head branch was pushed to by a user without write access

@T-Gro T-Gro merged commit 24345e6 into dotnet:main Sep 19, 2023
@kerams kerams deleted the sug branch September 19, 2023 09:17
@allisonchou allisonchou mentioned this pull request Sep 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vzarytovskii vzarytovskii vzarytovskii left review comments

@T-Gro T-Gro T-Gro approved these changes

+1 more reviewer

@psfinaki psfinaki psfinaki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kerams @vzarytovskii @psfinaki @T-Gro