Update Roslyn to base off beta6 version of Roslyn + Type Colorization#1581
Merged
OmarTawfik merged 10 commits intodotnet:roslynfrom Oct 6, 2016
OmarTawfik:roslyn
Merged
Update Roslyn to base off beta6 version of Roslyn + Type Colorization#1581OmarTawfik merged 10 commits intodotnet:roslynfrom OmarTawfik:roslyn
OmarTawfik merged 10 commits intodotnet:roslynfrom
OmarTawfik:roslyn
Conversation
added 7 commits
October 5, 2016 14:06
Contributor
Author
|
Update. PR dotnet/roslyn#14317 is for the removal of DocumentDifferenceService. |
|
Looks reasonable to me :) |
KevinRansom
suggested changes
Oct 6, 2016
| projectSite.Initialize(hier, site) | ||
| let projectContextFactory = this.Package.ComponentModel.GetService<IWorkspaceProjectContextFactory>(); | ||
| let errorReporter = ProjectExternalErrorReporter(projectId, "FS", this.SystemServiceProvider) | ||
| let outputFlag = (site.CompilerFlags() |> Seq.find(fun flag -> flag.StartsWith("-o:"))).Substring(3) |
Contributor
There was a problem hiding this comment.
This is also legal:
--out: Name of the output file (Short form: -o)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Microsoft/fsharp-compiler @CyrusNajmabadi