Included existing NoWarn value #15444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psfinaki
approved these changes
Jun 20, 2023
Contributor
psfinaki
left a comment
There was a problem hiding this comment.
I think <NoWarn>$(NoWarn);(all the other warnings)</NoWarn> is the right approach.
Contributor
Author
|
@psfinaki I was more referring to the |
Contributor
|
Hmm I suspect MSBuild would default a random number to C# compiler warnings. I cannot find explicit docs on that, although these explanations kind of imply that. Either way, FS0075 is more safe and explicit. |
Member
|
@psfinaki it's not an MSBuild behavior, rather Roslyn chooses to interpret pure numbers as having the CS prefix. This is not considered good practice anymore in a world of many different components providing diagnostics (analyzers, linker, nuget, etc) and so we should always fully qualify these days. |
KevinRansom
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an extra value
NoWarnvalue in myDirectory.Build.props.user.This would allow it to come through in
src/FSharp.Build/FSharp.Build.fsproj.PS: When do you use
<NoWarn>$(NoWarn);75</NoWarn>versus<NoWarn>FS0075</NoWarn>?