Skip to content

Enable prebuilt detection #15209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vzarytovskii merged 7 commits into from
May 16, 2023
Merged

Enable prebuilt detection #15209

vzarytovskii merged 7 commits into from
May 16, 2023

Conversation

@NikolaMilosavljevic
Copy link
Member

@NikolaMilosavljevic NikolaMilosavljevic commented May 10, 2023

Fixes: #15166

This change enables prebuilt detection, for source-build.

After this is merged, I will add a subscription for https://github.com/dotnet/source-build-reference-packages

@NikolaMilosavljevic NikolaMilosavljevic requested a review from a team as a code owner May 10, 2023 16:12
@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented May 10, 2023

@MichaelSimons @mthalman @mmitche

@vzarytovskii
Copy link
Member

vzarytovskii commented May 10, 2023

Is there a reason helix getting removed? Is it implicit?

@vzarytovskii
Copy link
Member

vzarytovskii commented May 10, 2023

Also, probably a good idea to retarget it for 17.7 branch, since it's getting inserted everywhere currently (7.0.4xx and main)

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented May 10, 2023

Is there a reason helix getting removed? Is it implicit?

It's part of Arcade toolset, so the explicit dependency isn't needed - @mmitche is this correct?

@NikolaMilosavljevic NikolaMilosavljevic changed the base branch from main to release/dev17.7 May 10, 2023 23:51
@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented May 11, 2023

Hmm, after retargeting to release/dev17.7 we are getting a bunch of new prebuilts - investigating...

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented May 11, 2023

Hmm, after retargeting to release/dev17.7 we are getting a bunch of new prebuilts - investigating...

Resolved all new issues.

MichaelSimons
MichaelSimons reviewed May 11, 2023
View reviewed changes
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request May 11, 2023
Closed
MichaelSimons
MichaelSimons reviewed May 11, 2023
View reviewed changes
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request May 11, 2023
Merged
NikolaMilosavljevic
NikolaMilosavljevic commented May 12, 2023
View reviewed changes
@vzarytovskii
Copy link
Member

vzarytovskii commented May 15, 2023

@NikolaMilosavljevic shall we merge it?

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented May 15, 2023

@NikolaMilosavljevic shall we merge it?

@mmitche any concerns with the question I had above? #15209 (comment)

@NikolaMilosavljevic
Copy link
Member Author

NikolaMilosavljevic commented May 15, 2023

@NikolaMilosavljevic shall we merge it?

Thanks @vzarytovskii - this is ready to be merged - I've synced with @mmitche offline.

@vzarytovskii vzarytovskii merged commit 53b6942 into dotnet:release/dev17.7 May 16, 2023
@NikolaMilosavljevic NikolaMilosavljevic mentioned this pull request May 16, 2023
Closed
@allisonchou allisonchou mentioned this pull request May 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelSimons MichaelSimons MichaelSimons left review comments

@vzarytovskii vzarytovskii vzarytovskii approved these changes

Assignees

No one assigned

Labels

release/17.7

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable source-build pre-built detection

3 participants

@NikolaMilosavljevic @vzarytovskii @MichaelSimons