Aggregation function for Array.Parallel module#14924
Merged
T-Gro merged 17 commits intodotnet:mainfrom Apr 20, 2023
Merged
Conversation
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
T-Gro
commented
Mar 21, 2023
Member
Author
|
/run fantomas |
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Contributor
|
Ran fantomas: https://github.com/dotnet/fsharp/actions/runs/4667730608 |
0101
approved these changes
Apr 11, 2023
tests/FSharp.Core.UnitTests/FSharp.Core.SurfaceArea.netstandard20.debug.bsl
Show resolved
Hide resolved
psfinaki
approved these changes
Apr 19, 2023
T-Gro
commented
Apr 19, 2023
T-Gro
commented
Apr 19, 2023
Co-authored-by: Petr <psfinaki@users.noreply.github.com>
T-Gro
commented
Apr 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last step of the RFC to expand the Array.Parallel module, based on approved suggestion .
This PR includes:
And two functions on which the implementation relies on:
The benchmarks used for the choice of implementation are here https://github.com/T-Gro/Array.Parallel.Aggs.Benchmark/tree/main/Results .
Among others, the following dimensions were already evaluated and lead to the choice of existing implemented solution: