Tests/parser: use test source #13403
Conversation
8621d74 to
e9fa0ca
Compare
|
It wasn't writing it to disk before either: fsharp/tests/service/Common.fs Line 197 in ddbaafd Which is probably the reason it didn't work for you during debug, because I don't like that this seems to be adding another obstacle to eventually being able to run tests in parallel. |
If/Once we are ready for parallelism, the storage could be turned into an (WeakMap option), keyed by randomly generated filename per test case. ? |
|
|
||
| let internal setTestSource source = | ||
| testSource <- Some source | ||
| { new IDisposable with |
There was a problem hiding this comment.
Could we maybe make the source accessible from this object? So that we can pass it to parseTestSource directly in the tests. That would make the test code a bit clearer and if we ever need to change how we store this we wouldn't need to change the tests.
|
Hey @auduchinok, is this still something of your interest? |
❗ Release notes requiredCaution No release notes found for the changed paths (see table below). Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format. The following format is recommended for this repository:
If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request. You can open this PR in browser to add release notes: open in github.dev
|
|
Caution Repository is on lockdown for maintenance, all merges are on hold. |
|
Doing clean up in PRs - please reopen if you deem appropriate |
An experiment with in-memory setting a test source that is used for parsing.
The current approach seems to rely on writing a file into temp directory and then trying to read it. It have never worked for me during debug. We could try to fix that, but not writing it to disk seems a better thing to do.