Skip to content

fix nameof bug for operators #10154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dsyme merged 2 commits into from
Sep 20, 2020
Merged

fix nameof bug for operators #10154

dsyme merged 2 commits into from
Sep 20, 2020

Conversation

@dsyme
Copy link
Contributor

@dsyme dsyme commented Sep 19, 2020

We have a bug #10143

First we fix the tests so they actually run. This reveals two existing failures

Failed  line 242
Failed  line 246

        let b = nameof(+)
        Assert.AreEqual ("line " + string __LINE__) ("+",b)

        let b3 = nameof(FSharp.Core.Operators.(+))
        Assert.AreEqual ("line " + string __LINE__) ("+",b3)

Obviously this has never worked.

@dsyme dsyme changed the title [WIP] fix nameof bug fix nameof bug for operators Sep 19, 2020
@dsyme
Copy link
Contributor Author

dsyme commented Sep 19, 2020

@cartermp This is ready (once green)

We lost the change related to operators during the development of the PR, and the tests weren't active to prevent this

@dsyme dsyme mentioned this pull request Sep 19, 2020
Closed
@dsyme dsyme merged commit 1013a8d into dotnet:main Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cartermp cartermp cartermp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dsyme @cartermp