Upgrade MSBuildLocator to version 1.6.1 #1948
Conversation
This includes several fixes around resolving hostfxr.
|
I updated the version of source-build-externals because the previous version contained 1.5.5 of MSBuildLocator. So this update to 1.6.1 cause a source-build prebuilt error to occur. The latest version of source-build-externals has version 1.6.1 so this should resolve the error. |
|
@JoeRobich or @sharwell, could you investigate the build errors? This change is needed to unblock code flow for the sdk: dotnet/installer#17319. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Looks like there are still failures for aspnetcore and efcore. |
| _targetSolution: "format.sln" | ||
| _branchName: "main" | ||
| _sha: "1ec992c6038af9d42499d3ac88c3fd65d0c2f6ed" | ||
| _sha: "452f6263277533da0af2b557003256d98fbecc27" |
There was a problem hiding this comment.
❔ Why update all of these?
There was a problem hiding this comment.
Habit. Although I see these repos are now on some very preview sdk versions
There was a problem hiding this comment.
If updating the dependency broke formatting for the previous SHA, doesn't that mean some users could see dotnet-format break for the same change?
|
@dotnet-policy-service rerun |
|
@mmitche - Can you help with this CLA issue? |
|
Nope. But I can merge around it! |
This includes several fixes around resolving hostfxr. (See microsoft/MSBuildLocator#230 & microsoft/MSBuildLocator#236)
resolves #1945