Skip to content

Remove hardcoded TFMs and replace powershell script with MSBuild projects #1814

@ViktorHofer

Description

@ViktorHofer

Two powershell scripts currently hardcode the TFM value:

  • $output = dotnet.exe "$currentLocation/artifacts/bin/dotnet-format/Release/net7.0/dotnet-format.dll" $solution --no-restore -v diag --verify-no-changes | Out-String
  • Invoke-Expression 'dotnet run -c Release -f net7.0 --runtimes net7.0 --project dotnet-format.Performance.csproj -- --memory --join --filter Microsoft.CodeAnalysis.Tools.Perf.Micro*'

While that wasn't a problem in the past, with now floating TFM versions defined by Arcade ($(NetCurrent)), the goal is to upgrade repositories to the next version of .NET more easily.

Ideally the two scripts would be replaced by simple msbuild projects (using the Microsoft.Build.NoTargets SDK) that achieve the exact same result (potentially with even less code). MSBuild has access to the entire repo infrastructure, including the NetCurrent proprerty and hence those hardcoded entries would go away.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions