Add model provider information to ChatTurnDetails#6722
Merged
shyamnamboodiripad merged 1 commit intodotnet:mainfrom Aug 15, 2025
Merged
Add model provider information to ChatTurnDetails#6722shyamnamboodiripad merged 1 commit intodotnet:mainfrom
shyamnamboodiripad merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds model provider information to the ChatTurnDetails class to provide better tracking of which provider is being used for AI model interactions. This enhances the evaluation reporting capabilities by including provider context alongside existing model information.
- Adds ModelProvider property to ChatTurnDetails class with appropriate constructor overloads
- Updates chat clients to populate the model provider information from ChatClientMetadata
- Enhances the TypeScript UI to display model provider information in a separate column
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ChatTurnDetails.cs | Adds ModelProvider property and new constructor overload with JSON serialization support |
| SimpleChatClient.cs | Retrieves and passes ChatClientMetadata.ProviderName to ChatTurnDetails |
| ResponseCachingChatClient.cs | Retrieves and passes ChatClientMetadata.ProviderName to ChatTurnDetails |
| ChatDetailsSection.tsx | Adds separate column for model provider in the UI table |
| Microsoft.Extensions.AI.Evaluation.Reporting.json | Updates API baseline with new property and constructor |
| ScenarioRunResultTests.cs | Updates test data to include modelProvider parameter |
| ResponseCacheTester.cs | Refactors inline variable usage and removes unused import |
| ChatTurnDetailsTests.cs | Adds comprehensive test coverage for ModelProvider serialization scenarios |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/Libraries/Microsoft.Extensions.AI.Evaluation.Reporting/CSharp/ResponseCachingChatClient.cs
Show resolved
Hide resolved
...es/Microsoft.Extensions.AI.Evaluation.Reporting/TypeScript/components/ChatDetailsSection.tsx
Show resolved
Hide resolved
peterwald
approved these changes
Aug 15, 2025
ce0cd3e to
e50bf6e
Compare
e50bf6e to
668cf14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow