[Suggestion] Centralize CorrelationIds#197
Closed
benaadams wants to merge 1 commit intodotnet:devfrom
Closed
Conversation
|
@muratg we should ping Svetlana's team to see what they're doing with correlation. |
Member
|
Why not leave it in HttpAbstractions? Kestrel and Hosting would have access to it there. Or does something else need it? |
Member
Author
|
@Tratcher was mostly a suggestion, I can make a PR there instead? |
|
Although only HttpAbstractions and Kestrel would use this right away, it's conceivable that something besides our http servers might be interested in generating unique IDs. It seems logical for this to be in Common. |
Member
Author
|
Don't think the lazy in this is correct, it should be on Id rather than string (but also string for string creation) |
|
@benaadams, good to close in this repo? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TraceIdentifier and ConnectionId repeat the same logic; there is no reason why they couldn't come from the same source. Also means a request's Id will be logically greater than its connection's id; and new connection id's will be greater than older requests rather than independent.
Other change is to use more of the numeric domain. Seed the release of ASP.NET Core as min Id. Seed current start as now+timestamp; increase the number of unique events per-second from 10 million to 1 billion to reduce chance of restart clash (overkill 😛 - but might be used for additional events).
/cc @davidfowl