Conversation
| private readonly ISqlGenerationHelper _sqlGenerationHelper; | ||
| private readonly IParameterNameGeneratorFactory _parameterNameGeneratorFactory; | ||
| private readonly IRelationalTypeMapper _relationalTypeMapper; | ||
| private static readonly bool _defaultUnicodeBehaviour = true; |
There was a problem hiding this comment.
nit: Move static above instance fields.
|
LGTM, cc @ajcvickers for TypeMapper changes. |
|
Providers beware? |
|
@ErikEJ yes. |
|
Are we setting the right unicodeness on parameters for update and delete statements for tables with non-Unicode string keys? I haven't tested it but I suspect performance of those could be affected by the same database limitation. |
| : base.FindMapping(clrType)); | ||
| } | ||
|
|
||
| public override RelationalTypeMapping FindMapping(Type clrType, bool unicode) |
There was a problem hiding this comment.
Factor these two methods into a single method rather than copy/pasting all the logic.
d3cd900 to
c4f2b6d
Compare
|
@divega - This PR does not make any modification to update pipeline. Is there any issue tracking it? |
|
@smitpatel there isn't a separate issue for updates. I can create one if you just want to get this in faster. |
|
This one is marked for RC2 milestone. Should get this in before the ask mode. 😄 |
|
Updated with all feedback. |
|
|
17f6157 to
d484f68
Compare
Part of #4686