[release/10.0] Revert "Fix View Indexes not Scaffolded in Sql Server (#37607)" #37634
Merged
AndriySvyryd merged 1 commit intorelease/10.0from Feb 5, 2026
Merged
[release/10.0] Revert "Fix View Indexes not Scaffolded in Sql Server (#37607)" #37634AndriySvyryd merged 1 commit intorelease/10.0from
AndriySvyryd merged 1 commit intorelease/10.0from
Conversation
This reverts commit 69eaf15.
roji
approved these changes
Feb 5, 2026
6 tasks
There was a problem hiding this comment.
Pull request overview
This PR reverts commit 69eaf15 which added support for scaffolding indexes on SQL Server views. The revert was necessary because the original commit was merged accidentally into the release/10.0 branch.
Changes:
- Removed CTE-based query that included views when scaffolding indexes, reverting to table-only index scaffolding
- Removed the test case that verified view index scaffolding functionality
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/EFCore.SqlServer/Scaffolding/Internal/SqlServerDatabaseModelFactory.cs | Reverts the GetIndexes method to query only sys.tables instead of combining tables and views via CTE |
| test/EFCore.SqlServer.FunctionalTests/Scaffolding/SqlServerDatabaseModelFactoryTest.cs | Removes the Create_indexes_on_views test that verified view index scaffolding |
This was referenced Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 69eaf15 that was merged accidentally.